Skip to content

Conversation

@moreorover
Copy link
Contributor

@moreorover moreorover commented Dec 27, 2025

closes #764

setup-catalogs.ts:70 should not care about package version I think. If a package is used twice, by default it should bring the dependency to catalog.

Summary by CodeRabbit

  • Chores
    • Bumped the @types/node development dependency to a newer patch release across the CLI and frontend templates to keep type tooling consistent.

✏️ Tip: You can customize this high-level summary in your review settings.


Note

Updates Node type definitions across the CLI and React template to a consistent version.

  • Bumps @types/node in apps/cli/src/constants.ts dependency map to ^22.13.14
  • Bumps @types/node in apps/cli/templates/frontend/react/tanstack-router/package.json.hbs devDependencies to ^22.13.14

Written by Cursor Bugbot for commit ff29303. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Dec 27, 2025

@moreorover is attempting to deploy a commit to the Better T Stack Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Bumps @types/node versions: in apps/cli/src/constants.ts from ^22.13.11 → ^22.13.14 and in apps/cli/templates/frontend/react/tanstack-router/package.json.hbs from ^22.13.13 → ^22.13.14.

Changes

Cohort / File(s) Summary
@types/node version bumps
apps/cli/src/constants.ts, apps/cli/templates/frontend/react/tanstack-router/package.json.hbs
Updated @types/node entries to ^22.13.14 in the CLI dependencyVersionMap and the TanStack Router frontend template devDependencies.

Possibly related PRs

  • PR 533 — Modifies the same dependencyVersionMap in apps/cli/src/constants.ts with dependency version updates.
  • PR 302 — Updates entries in dependencyVersionMap within apps/cli/src/constants.ts.
  • PR 724 — Adjusts multiple entries in dependencyVersionMap in apps/cli/src/constants.ts.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Changes update @types/node versions in two files but don't implement catalog approach described in issue #764 to centralize version in pnpm-workspace.yaml. Implement the catalog-based approach in pnpm-workspace.yaml and update package.json files to use 'catalog:' references as specified in issue #764.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: @types/node versions' accurately describes the main change—updating @types/node versions across files.
Out of Scope Changes check ✅ Passed All changes are version updates to @types/node in constants.ts and package.json.hbs, directly related to issue #764 scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7fe9e6 and ff29303.

📒 Files selected for processing (1)
  • apps/cli/src/constants.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AmanVarshney01 AmanVarshney01 enabled auto-merge (squash) December 28, 2025 15:45
@AmanVarshney01 AmanVarshney01 merged commit b74f45c into AmanVarshney01:main Dec 28, 2025
2 of 3 checks passed
@moreorover moreorover deleted the fix/types-node branch December 29, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: @types/node dependency pinned through every package individually

2 participants