Make all mbufs single segment #731
Merged
+86
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit patches create_pktmbuf_pool() to guarantee that mbufs have enough dataroom for the largest frame possible, so all mbufs in Gatekeeper are single segment.
All mbufs in Gatekeeper are single segment, so scatter is not needed.
All mbufs in Gatekeeper are single segment.
See issue #730 for more information on the bug that this workaround circumvents.
AltraMayor
added
bug
enhancement
workaround available
Owner
Author
|
This pull request has successfully passed all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless all mbufs are single segment, PMD drivers that support vectorial receiving and transmission won't enable those vectorial paths. Notice that having single-segment mbufs is not the only requirement for vectorial paths; it's a big requirement.
This pull request also includes an MTU workaround for the ICE driver.
This pull request closes #698.