-
Notifications
You must be signed in to change notification settings - Fork 252
chore: capture and report axelar scan error messages #12288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+60
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazarshad
approved these changes
Dec 18, 2025
Comment on lines
235
to
237
| ...(result.rejectionReason | ||
| ? { rejectionReason: result.rejectionReason } | ||
| : {}), |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor:
...({}) ill result in rejectReason: undefined anyway
Suggested change
| ...(result.rejectionReason | |
| ? { rejectionReason: result.rejectionReason } | |
| : {}), | |
| rejectReason: result.rejectionReason || undefined |
d7f3528 to
84c814d
Compare
84c814d to
39e1837
Compare
Contributor
Merge Queue Status✅ The pull request has been merged at 39e1837 This pull request spent 7 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge:rebase
Automatically rebase updates, then merge
bypass:integration
Prevent integration tests from running on PR
ymax
IOU
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes:
Description
When a GMP transaction fails on the destination EVM chain, the error message from Axelar scan is now extracted and passed as the rejection reason when the resolver tries to settle the transaction.