Add constraints binding #1679
Add constraints binding #1679
Conversation
|
Clippy will be fixed with #1678 |
hratoanina
left a comment
hratoanina
left a comment
There was a problem hiding this comment.
LGTM, only minor nits.
SyxtonPrime
left a comment
SyxtonPrime
left a comment
There was a problem hiding this comment.
I think this looks reasonably good (Though I'm not really familiar with this codebase, I joined after we had switched to Plonky3).
Do you think it would be possible to add some comments to the Prover explaining the idea behind the commitment and to the verifier/recursive_verifier showing more clearly where this is checked? (I struggled a little to understand where the verifier was checking the provers commitment)
SyxtonPrime
left a comment
SyxtonPrime
left a comment
There was a problem hiding this comment.
Looks good, just a couple of minor comments
Nashtare
left a comment
Nashtare
left a comment
There was a problem hiding this comment.
Thanks @LindaGuiga! Looking good! I hust have minor comments on some method arguments otherwise seems good to go
This PR aims at binding the STARK constraints to the challenges used in the quotient polynomials.
@SyxtonPrime Does this look good to you?