Allow multiple extra_looking_sums for the same looked table
#1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Jun 4, 2024
Collaborator
|
|
Nashtare
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ctl_extra_looking_sumscorresponds to the index of the looked table. The problem with this is that it is not possible to set anotherextra_looking_sumsfor the same looked table. For example, in zk_evm'skeccak_stark, there are two CTLs for the same looked table, and therefore, it is not possible to use those two CTLs asextra_looking_sums. I addressed this issue by changing the type ofctl_extra_looking_sumsto aHashMapsimilar tocheck_ctl, and making it correspond one-to-one with the index of the CTL.