Fix CTL generation of last row #1585
Conversation
matthiasgoergens
requested review from
Nashtare,
muursh and
wborgeaud
as code owners
Not all `correct` cross table lookups use padding for the last row.
matthiasgoergens
force-pushed
the
matthias/ctl/fix-last
branch
from
d6faf1e to
04e765a
Compare
| } | ||
|
|
||
| res | ||
| .map(|&(c, f)| table[c].values[(row + 1) % table[c].values.len()] * f) |
There was a problem hiding this comment.
If you are worried about performance, you could also do & (table[c].values.len() - 1), taking advantage of the fact that we only work with powers of two. But this is confusing, and modern processors are fast.
On a wider scale, I thought of doing linear combinations on whole columns at once via batch_add_inplace etc, but it's not really worth it, because CTL data generation is such a small part of overall runtime.
There was a problem hiding this comment.
If you are worried about performance, you could also do & (table[c].values.len() - 1), taking advantage of the fact that we only work with powers of two.
I don't mind having it (with an eventual comment for clarity), but this isn't an actual bottleneck at all anyway so probably negligible as you mentioned.
Not all `correct` cross table lookups use padding for the last row.
3 participants
Not all
correctcross table lookups use padding for the last row.