Fix verify_cross_table_lookups with no ctl_extra_looking_sums
#1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
requested review from
Nashtare,
muursh and
wborgeaud
as code owners
LindaGuiga
reviewed
Apr 25, 2024
Contributor
LindaGuiga
left a comment
LindaGuiga
left a comment
There was a problem hiding this comment.
Thank you for fixing this, @matthiasgoergens !
This used to fail with an out of bounds error when `None` was passed for `ctl_extra_looking_sums`.
matthiasgoergens
force-pushed
the
matthias/fix-no-ctl_extra_looking_sums
branch
from
a2c1aed to
6576a22
Compare
Nashtare
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to fail with an out of bounds error when
Nonewas passed forctl_extra_looking_sums.