-
Notifications
You must be signed in to change notification settings - Fork 152
docs:hooks #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
docs:hooks #1636
Conversation
Introduced documentation guidelines and discovery rules for WordPress hooks in the project. Added initial hook list in docs/hooks/HOOKLIST.MD, and started documenting several action and filter hooks in docs/hooks/actions.md and docs/hooks/filters.md. Updated .gitignore to ignore 'cursor' instead of '.cursor'. Created supporting documentation files and rules for consistent hook documentation.
Updated HOOKLIST.MD to enumerate and mark all action and filter hooks as documented. Added detailed documentation for all action and filter hooks in actions.md and filters.md, including parameters, return values, categories, and descriptions. Also updated .gitignore to ignore .cursor instead of cursor.
WalkthroughThis update introduces comprehensive documentation for the WP User Frontend plugin hooks, including detailed references for all action and filter hooks and a master list of available hooks. Additionally, a previously ignored test image file is re-added to the Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/hooks/list.md (1)
155-159
: Note section contradicts the tableThe note claims “All hooks are marked as No in the documented column initially”, yet every entry above is currently flagged Yes (except the two Appsero filters).
Either update the note or switch the undocumented hooks back to “No” to avoid misleading readers.docs/hooks/actions.md (1)
891-898
: Inconsistent capitalisation – verify actual hook spelling
WPUF_multidropdown_field_after_label
is capitalised, whereas WordPress convention (and WP-UF source) uses lowercase (wpuf_multidropdown_field_after_label
).
Confirm the exact hook name and normalise – otherwise sample code that copies from the docs will silently fail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.gitignore
(1 hunks)docs/hooks/actions.md
(1 hunks)docs/hooks/filters.md
(1 hunks)docs/hooks/list.md
(1 hunks)
🔇 Additional comments (4)
.gitignore (1)
35-35
: Addition looks good – keeps binary test artefact out of the repoNothing else to flag.
docs/hooks/list.md (1)
53-57
: Potential duplicate / conflicting hook namesRows 54 – 57 list both the underscore and the hyphen variants of the same “form-builder settings tabs” hooks (
wpuf_form_builder_settings_tabs_{form_type}
vswpuf-form-builder-settings-tabs-{form_type}
, etc.).
Please check the source-code calls (do_action
) – only one naming style is usually present in core. Keeping both will confuse users and inflate the tally.docs/hooks/actions.md (1)
690-740
: Same hook group repeated with two naming schemesThe block for the form-builder hooks includes both:
wpuf_form_builder_settings_tabs_{form_type}
(underscores)wpuf-form-builder-settings-tabs-{form_type}
(hyphens)Only one form actually exists in code. Having both here introduces duplication and will break copy-paste usage for developers. Please grep the codebase and keep the authoritative spelling.
docs/hooks/filters.md (1)
19-24
: Missing documentation for filters marked “No” in hook list
docs/hooks/list.md
flagsappsero_endpoint
andappsero_is_local
as undocumented (“No”). They are not present in this file, so the status is correct – but the list will remain inconsistent until you add corresponding sections or flip the status to “Yes” only after docs land.
documentation for a list of hooks created across WP user frontend plugin
Summary by CodeRabbit
Documentation
Chores