[Bugfix] Fix triton import precommit failure #25803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Michael Smith <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a pre-commit failure by centralizing the import of triton. The change in vllm/model_executor/layers/batch_invariant.py replaces a direct import of triton and triton.language with an import from vllm.triton_utils. This is the correct approach for handling this optional dependency within the project, ensuring consistency and proper behavior when Triton is not installed. The fix is sound and I have no further recommendations.
robertgshaw2-redhat
approved these changes
Sep 27, 2025
github-actions
bot
added
the
ready
mgoin
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #25603, but not sure why the last commit passed the precommit there. I'm hitting precommit failures locally when merging main.