Skip to content

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Sep 22, 2025

Purpose

Remove V0 code path from the following models:

  • Mamba1
  • Mamba2
  • Minimax (LinearAttention)
  • LFM (ShortConv)
  • Qwen3-Next (GDN)
  • Bamba
  • Jamba
  • Nemotron-H
  • GraniteMoeHybrid
  • Plamo2
  • Zamba
  • Falcon-H

Please now that the model phi4flash has not been ported to V1 yet (#23996) and is non-trival to do so (requires porting differential attention backend). This PR removes the modeling code for that model. It can be re-added once the porting is done. The code will be useless until then anyway since V0 has been removed.

Test Plan

Hybrid model test should verify nearly all of the above. I have run it locally. Let's see what happens in CI.

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
@mergify mergify bot added the v1 label Sep 22, 2025
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
@mergify mergify bot added the qwen Related to Qwen models label Sep 22, 2025
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 22, 2025
@mergify mergify bot added the new-model Requests to new models label Sep 23, 2025
@WoosukKwon WoosukKwon merged commit a903669 into vllm-project:main Sep 23, 2025
53 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model Requests to new models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants