Revert "[Metrics] Hide deprecated metrics with gpu_ prefix (#24245)" #25392
+46
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#24245)" This change is intended for 0.11.0. This reverts commit 2942970.
markmc
requested review from
DarkLight1337,
robertgshaw2-redhat,
simon-mo,
aarnphm,
NickLucche,
WoosukKwon,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that hid deprecated metrics with a gpu_ prefix. The revert correctly makes these metrics always visible again by removing the conditional logic. However, there's an inconsistency in the test changes. While the deprecated metrics are un-hidden, the corresponding newer metrics (vllm:kv_cache_usage_perc, etc.) are removed from the EXPECTED_METRICS_V1 test list, even though they are still being emitted by the application. This reduces test coverage, and I've left a comment to address this.
|
Actually let's wait, because @WoosukKwon recently merged most of the V0 deprecation code so there is a chance the release can still be v0.11. cc @simon-mo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended for 0.11.0.
This reverts commit 2942970.