-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[V0 Deprecation][KVConnector] Remove KVConnector v1/v0 differentiation #25376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request completes the deprecation of KVConnector V0 by refactoring the file structure and class names to remove the 'v1' differentiation. The changes primarily involve moving files from v1/kv_connector
to kv_connector
, renaming KVConnectorBase_V1
to KVConnectorBase
, and updating all related paths and imports across the codebase.
My review has identified a critical issue where a file was copied instead of moved, leading to code duplication. I've also pointed out a now-redundant function that should be removed to finalize the cleanup. Apart from these points, the refactoring looks consistent and well-executed.
lgtm apart from the 2 helpful gemini comments Splitting a 2 minute set of unit tests out in its own job seems a bit excessive, no? |
Thanks for reviewing!
Yeah I was hoping to run the nixl_integrations one too and start a separate namespace with the hope of getting more tests in.. let me revert that |
Signed-off-by: NickLucche <[email protected]>
@NickLucche I think we need to keep the V1 interface classes in their current locations as aliases for backwards compatibility. See for example what was done with |
I'm actually not sure we should rush to move the V1 classes yet. We can clear out all of the v0 things but should keep the v1 naming/structure for a while (e.g. a release or two at least). I think removing v0 and moving v1 all at the same time has potential to introduce more confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with @njhill
Sounds good, will keep things like this. We can go back to cleaning up the codebase at a later time. |
This pull request has merge conflicts that must be resolved before it can be |
This PR completes the KVConnector V0 deprecation we started here #21785.
It mostly moves stuff from
v1/kv_connector
tokv_connector
to clarify there is no other "vX" connector (since removed in the above PR) .Takes care of v1-related naming + warning as well (eg checking v1 is enabled).
List of changes:
KVConnectorBase_V1->KVConnectorBase
KVConnectorBaseType = KVConnectorBase_V1
vllm/distributed/kv_transfer/v1/kv_connector/
->vllm/distributed/kv_transfer/kv_connector/
tests/v1/kv_connector
->tests/kv_connector
KV Connector Test
CI jobcc @lk-chen