Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 14, 2025

Purpose

Test Plan

pytest -s -v tests/models/multimodal/processing/test_glm4_1v.py -k test_processor_override

Test Result

Test should pass.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) labels Sep 14, 2025
@Isotr0py Isotr0py marked this pull request as ready for review September 14, 2025 18:04
@DarkLight1337
Copy link
Member

Let's see if transformers nightly passes now

@DarkLight1337
Copy link
Member

DarkLight1337 commented Sep 15, 2025

Well, Intern-S1 is still failing, so can't check it

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 15, 2025
@DarkLight1337
Copy link
Member

Oh, this breaks the existing processor test

Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
Copy link
Member Author

Well, Intern-S1 is still failing, so can't check it

I see, let me check it with nightly Transformers locally then.

@Isotr0py
Copy link
Member Author

Have confirmed v4.56.1 and v4.57.0.dev(huggingface/transformers@9c804f7) can still pass the GLM4.1V tests in tests/models/multimodal/processing/test_glm4_1v.py and tests/models/multimodal/processing/test_common.py

@DarkLight1337 DarkLight1337 merged commit 0e219cd into vllm-project:main Sep 15, 2025
50 checks passed
@Isotr0py Isotr0py deleted the fix-glm4.1v-sample branch September 15, 2025 12:53
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants