-
Notifications
You must be signed in to change notification settings - Fork 459
[CI] Upgrade vllm to newest commit #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the import path for PoolerOutput to maintain compatibility with a newer version of vLLM. The change introduces a conditional import based on the vLLM version.
My review identifies a potential issue with the version checking logic. The current implementation uses an exact equality check, which is not robust for handling a range of vLLM versions and could lead to ImportError with older versions. I've provided a suggestion to use proper version comparison for a more robust solution.
22572dc to
30ff60e
Compare
Signed-off-by: wangxiyuan <[email protected]>
0f23dea to
5c89882
Compare
Signed-off-by: wangxiyuan <[email protected]>
5c89882 to
fee651c
Compare
Signed-off-by: wangxiyuan <[email protected]>
153395c to
4bd80fa
Compare
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
|
service "Skipping ACL graph capture" in this version |
|
@sanlio36 what's your vLLM version? |
### What this PR does / why we need it? Upgrade vLLM to newest commit - Fix the aclgraph doesn't work problem, caused by vllm-project/vllm@24fab45 - Fix PoolerOutput import error, caused by vllm-project/vllm@755ed7b - Fix the aclgraph weight load error to keep the same with torchair fix. vllm-project/vllm@4492e3a ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? All test should pass - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@52d0cb8 --------- Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: huangdong2022 <[email protected]>
What this PR does / why we need it?
Upgrade vLLM to newest commit
Does this PR introduce any user-facing change?
No
How was this patch tested?
All test should pass
Co-Authored-By: lilinsiman [email protected]