Skip to content

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Sep 25, 2025

What this PR does / why we need it?

Upgrade vLLM to newest commit

Does this PR introduce any user-facing change?

No

How was this patch tested?

All test should pass

Co-Authored-By: lilinsiman [email protected]

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the import path for PoolerOutput to maintain compatibility with a newer version of vLLM. The change introduces a conditional import based on the vLLM version.

My review identifies a potential issue with the version checking logic. The current implementation uses an exact equality check, which is not robust for handling a range of vLLM versions and could lead to ImportError with older versions. I've provided a suggestion to use proper version comparison for a more robust solution.

@wangxiyuan wangxiyuan force-pushed the update_vllm_version branch 2 times, most recently from 0f23dea to 5c89882 Compare September 25, 2025 12:37
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
@wangxiyuan wangxiyuan added ready read for review ready-for-test start test by label for PR labels Sep 25, 2025
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
@Yikun Yikun merged commit 2930e4a into vllm-project:main Sep 25, 2025
19 checks passed
@Yikun Yikun added vllm-break and removed ready-for-test start test by label for PR labels Sep 26, 2025
@sanlio36
Copy link

service "Skipping ACL graph capture" in this version

@wangxiyuan
Copy link
Collaborator Author

@sanlio36 what's your vLLM version?

huangdong2022 pushed a commit to huangdong2022/vllm-ascend that referenced this pull request Sep 26, 2025
### What this PR does / why we need it?
Upgrade vLLM to newest commit

- Fix the aclgraph doesn't work problem, caused by
vllm-project/vllm@24fab45
- Fix PoolerOutput import error, caused by
vllm-project/vllm@755ed7b
- Fix the aclgraph weight load error to keep the same with torchair fix.
vllm-project/vllm@4492e3a

### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
All test should pass

- vLLM version: v0.10.2
- vLLM main:
vllm-project/vllm@52d0cb8

---------

Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: huangdong2022 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants