Refactor ci to reuse base workflow and re-enable ut coverage #3064
+261
−293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Yikun
force-pushed
the
refactor-ci-2
branch
from
0d9cdcb to
12c0255
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Yikun
force-pushed
the
refactor-ci-2
branch
from
12c0255 to
cf35706
Compare
Yikun
force-pushed
the
refactor-ci-2
branch
from
cf35706 to
22d7776
Compare
Yikun
changed the title
^ Light test is expected 
|
Signed-off-by: Yikun Jiang <[email protected]>
Yikun
force-pushed
the
refactor-ci-2
branch
from
22d7776 to
5646608
Compare
wangxiyuan
approved these changes
Sep 21, 2025
Yikun
pushed a commit
that referenced
this pull request
Sep 22, 2025
### What this PR does / why we need it? Followup on #3064 1. should limit vllm version to the same hash with mypy 2. fix the vllm version bug for e2e light test. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: wangxiyuan <[email protected]>
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Sep 22, 2025
…oject#3064) ### What this PR does / why we need it? 1. Refactor ci to reuse base workflow and enable main 2 hours trigger job: - Extract e2e test in to _e2e_test.yaml - Reuse _e2e_test in light / full job - Enable main 2 hours trigger job 2. Rename e2e test to ascend test to make sure action display label 3. Re-enable ut coverage which was failed since vllm-project@5bcb4c1 and disable on vllm-project@6d8bc38 ### Does this PR introduce _any_ user-facing change? Only developer behavior changes: - Every job trigger full test with vllm release and hash - Run full job per 2 hours with vllm main - e2e light test (30 mins): `lint` (6mins) ---> ut (10mins) ---> `v0.10.2 + main / 4 jobs` (15mins) - e2e full test (1.5h): `ready label` ---> `v0.10.2 + main / 4 jobs`, about 1.5h - schedule test: 2hours ---> `v0.10.2 + main / 4 jobs`, about 1.5h ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: Yikun Jiang <[email protected]>
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Sep 22, 2025
) ### What this PR does / why we need it? Followup on vllm-project#3064 1. should limit vllm version to the same hash with mypy 2. fix the vllm version bug for e2e light test. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: wangxiyuan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
…oject#3064) ### What this PR does / why we need it? 1. Refactor ci to reuse base workflow and enable main 2 hours trigger job: - Extract e2e test in to _e2e_test.yaml - Reuse _e2e_test in light / full job - Enable main 2 hours trigger job 2. Rename e2e test to ascend test to make sure action display label 3. Re-enable ut coverage which was failed since vllm-project@5bcb4c1 and disable on vllm-project@6d8bc38 ### Does this PR introduce _any_ user-facing change? Only developer behavior changes: - Every job trigger full test with vllm release and hash - Run full job per 2 hours with vllm main - e2e light test (30 mins): `lint` (6mins) ---> ut (10mins) ---> `v0.10.2 + main / 4 jobs` (15mins) - e2e full test (1.5h): `ready label` ---> `v0.10.2 + main / 4 jobs`, about 1.5h - schedule test: 2hours ---> `v0.10.2 + main / 4 jobs`, about 1.5h ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
) ### What this PR does / why we need it? Followup on vllm-project#3064 1. should limit vllm version to the same hash with mypy 2. fix the vllm version bug for e2e light test. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
…oject#3064) ### What this PR does / why we need it? 1. Refactor ci to reuse base workflow and enable main 2 hours trigger job: - Extract e2e test in to _e2e_test.yaml - Reuse _e2e_test in light / full job - Enable main 2 hours trigger job 2. Rename e2e test to ascend test to make sure action display label 3. Re-enable ut coverage which was failed since vllm-project@5bcb4c1 and disable on vllm-project@6d8bc38 ### Does this PR introduce _any_ user-facing change? Only developer behavior changes: - Every job trigger full test with vllm release and hash - Run full job per 2 hours with vllm main - e2e light test (30 mins): `lint` (6mins) ---> ut (10mins) ---> `v0.10.2 + main / 4 jobs` (15mins) - e2e full test (1.5h): `ready label` ---> `v0.10.2 + main / 4 jobs`, about 1.5h - schedule test: 2hours ---> `v0.10.2 + main / 4 jobs`, about 1.5h ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
) ### What this PR does / why we need it? Followup on vllm-project#3064 1. should limit vllm version to the same hash with mypy 2. fix the vllm version bug for e2e light test. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@c60e613 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Does this PR introduce any user-facing change?
Only developer behavior changes:
lint(6mins) ---> ut (10mins) --->v0.10.2 + main / 4 jobs(15mins)ready label--->v0.10.2 + main / 4 jobs, about 1.5hv0.10.2 + main / 4 jobs, about 1.5hHow was this patch tested?
CI passed