Increase doctest timeout to 300s and time print #3041
Merged
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yikun Jiang <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
wangxiyuan
approved these changes
Sep 19, 2025
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Sep 22, 2025
### What this PR does / why we need it? Increase doctest timeout to 300s and time print, according to time print in vllm-project#3045 , most of time consumed in `Graph capturing`, so I think it's fine to increase doctest timeout This PR also add time log for each task. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Run `/vllm-workspace/vllm-ascend/tests/e2e/run_doctests.sh` - CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@a684c01 Closes: vllm-project#3045 Signed-off-by: Yikun Jiang <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
### What this PR does / why we need it? Increase doctest timeout to 300s and time print, according to time print in vllm-project#3045 , most of time consumed in `Graph capturing`, so I think it's fine to increase doctest timeout This PR also add time log for each task. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Run `/vllm-workspace/vllm-ascend/tests/e2e/run_doctests.sh` - CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@a684c01 Closes: vllm-project#3045 Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Sep 22, 2025
### What this PR does / why we need it? Increase doctest timeout to 300s and time print, according to time print in vllm-project#3045 , most of time consumed in `Graph capturing`, so I think it's fine to increase doctest timeout This PR also add time log for each task. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Run `/vllm-workspace/vllm-ascend/tests/e2e/run_doctests.sh` - CI passed - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@a684c01 Closes: vllm-project#3045 Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Increase doctest timeout to 300s and time print, according to time print in #3045 , most of time consumed in
Graph capturing, so I think it's fine to increase doctest timeoutThis PR also add time log for each task.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run
/vllm-workspace/vllm-ascend/tests/e2e/run_doctests.shCI passed
vLLM version: v0.10.2
vLLM main: vllm-project/vllm@a684c01
Closes: #3045