-
Notifications
You must be signed in to change notification settings - Fork 460
Refactor ci to reuse base workflow #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
9738b67
to
e17365d
Compare
Better to merge this after #2907 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3018 +/- ##
==========================================
- Coverage 74.76% 71.95% -2.82%
==========================================
Files 150 168 +18
Lines 20891 23547 +2656
==========================================
+ Hits 15620 16943 +1323
- Misses 5271 6604 +1333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8d93f4a
to
6dac138
Compare
Signed-off-by: Yikun Jiang <[email protected]>
What this PR does / why we need it?
Note for current e2e test behavior:
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed