Skip to content

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Sep 18, 2025

What this PR does / why we need it?

  1. Refactor ci to reuse base workflow and enable main 2 hours trigger job:
  • Extract e2e test in to _e2e_test.yaml
  • Reuse _e2e_test in light / full job
  • Enable main 2 hours trigger job
  1. Rename e2e test to ascend test to make sure action display label

Note for current e2e test behavior:

  • Every job trigger full test with vllm release and hash
  • Run full job per 2 hours with vllm main

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Yikun Yikun force-pushed the refactor-ci branch 8 times, most recently from 9738b67 to e17365d Compare September 19, 2025 03:24
@Yikun Yikun added ready read for review ready-for-test start test by label for PR and removed ready read for review ready-for-test start test by label for PR labels Sep 19, 2025
@Yikun Yikun added ready read for review ready-for-test start test by label for PR labels Sep 19, 2025
@Yikun Yikun removed ready read for review ready-for-test start test by label for PR labels Sep 19, 2025
@Yikun
Copy link
Collaborator Author

Yikun commented Sep 19, 2025

Better to merge this after #2907

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Yikun
Copy link
Collaborator Author

Yikun commented Sep 20, 2025

image

Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.95%. Comparing base (1bbb20e) to head (0d9cdcb).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
- Coverage   74.76%   71.95%   -2.82%     
==========================================
  Files         150      168      +18     
  Lines       20891    23547    +2656     
==========================================
+ Hits        15620    16943    +1323     
- Misses       5271     6604    +1333     
Flag Coverage Δ
unittests 71.95% <ø> (-2.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun Yikun added ready read for review ready-for-test start test by label for PR labels Sep 20, 2025
@Yikun Yikun force-pushed the refactor-ci branch 2 times, most recently from 8d93f4a to 6dac138 Compare September 20, 2025 11:27
@Yikun Yikun added accuracy-test enable all accuracy test for PR performance-test enable performance test for PR ready-for-test start test by label for PR ready read for review and removed ready read for review ready-for-test start test by label for PR labels Sep 20, 2025
@Yikun Yikun closed this Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy-test enable all accuracy test for PR performance-test enable performance test for PR ready read for review ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant