5579 - correct spelling error and introduce constant to avoid duplication #5582
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjvester
requested review from
helloanoop,
maintainer-bruno,
bijin-bruno,
lohit-bruno and
naman-bruno
as code owners
5 tasks
helloanoop
previously approved these changes
Sep 18, 2025
|
@johnjvester The CI is failing 
|
@helloanoop thank you for the heads-up. I've made an additional commit, to make sure the constant is not defined within an existing block. Once you ✅ we can see if CI is okay with this change now. |
|
@helloanoop @bijin-bruno @lohit-bruno @naman-bruno — could I please get a 👀 and ✅ on this minor update? Looks like CI has passed. |
helloanoop
approved these changes
Sep 23, 2025
|
Merged. Thanks @johnjvester ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5579 - correct spelling error and introduce constant to avoid duplication
While testing Bruno I noticed the incorrect spelling of "occured" in an error message that was returned when making a request. See the #5579 ticket for more details.
This PR corrects the spelling. While reviewing the code, the misspelling was duplicated in three places, so I created a constant to avoid duplication of the same string.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.