Using matrix in GHA for docker images #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
commented
Aug 21, 2025
Comment on lines
+93
to
+95
| type=registry,ref=${{ env.DOCKER_REGISTRY }}/${{ matrix.target.image }}-cache:${{ steps.meta.outputs.version }} | ||
| type=registry,ref=${{ env.DOCKER_REGISTRY }}/${{ matrix.target.image }}-cache:main-latest | ||
| cache-to: type=registry,ref=${{ env.DOCKER_REGISTRY }}/${{ matrix.target.image }}-cache:${{ steps.meta.outputs.version }},mode=max |
There was a problem hiding this comment.
We could reuse the same cache for all the images I guess, but for now we have different caches for each image. Note that this is a non-issue anyway, since the caches are stored in our Google docker registry and not in Github caches.
|
This is the kiss of death for our CI, you'll instigate the same ci flooding effect as we had for marshomono. There's a better way building this which I think I did somewhere... I'll see if I can dig it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40