Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@lyh169
Copy link
Contributor

@lyh169 lyh169 commented Aug 14, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #3240 (35bbc61) into dev (f438319) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 35bbc61 differs from pull request most recent head a958305. Consider uploading reports for the commit a958305 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3240      +/-   ##
==========================================
- Coverage   36.57%   36.57%   -0.01%     
==========================================
  Files         444      444              
  Lines       46663    46663              
==========================================
- Hits        17067    17065       -2     
- Misses      28330    28331       +1     
- Partials     1266     1267       +1     

see 1 file with indirect coverage changes

@lyh169 lyh169 requested a review from ItsFunny August 14, 2023 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants