Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@bylingo
Copy link
Contributor

@bylingo bylingo commented Aug 3, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@bylingo bylingo marked this pull request as ready for review August 3, 2023 09:20
@bylingo bylingo requested review from KamiD, chengzhinei and xzav3r August 3, 2023 09:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #3237 (09fff79) into dev (f438319) will not change coverage.
The diff coverage is n/a.

❗ Current head 09fff79 differs from pull request most recent head 321e959. Consider uploading reports for the commit 321e959 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3237   +/-   ##
=======================================
  Coverage   36.57%   36.57%           
=======================================
  Files         444      444           
  Lines       46663    46663           
=======================================
  Hits        17067    17067           
  Misses      28330    28330           
  Partials     1266     1266           

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants