Clean up independent feature masking in FeatureAblation #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarahtranfb has exported this pull request. If you are a Meta employee, you can view the originating diff in D83110168. |
…a-pytorch#1649) Summary: Defaulted to true everywhere in D81948483 stack Differential Revision: D83107514
Summary: No longer needed when enable_cross_tensor_attribution=False is no longer supported in the FeatureAblation parent class Differential Revision: D83109001
…#1651) Summary: Finally. Differential Revision: D83110168
sarahtranfb
force-pushed
the
export-D83110168
branch
from
7600afd to
a7f0eeb
Compare
|
@sarahtranfb has exported this pull request. If you are a Meta employee, you can view the originating diff in D83110168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Finally.
Differential Revision: D83110168