fix: cookie not sent problem in desktop #1220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After upgrade electron, search is not available for netease and bilibili for desktop app.
Reason
It seems electron use more strict cookie access when make cross domain request. Cookie should set sameSite to no-restriction instead of lax to let request bring cookie in local.
And netease has change auth method as well, now NMTID cookie should be provided, but value is not checked.
Solution
no-restriction
Future work