Improved fix to assure only one instance is running. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command 'pgrep -o -f "$APPNAME"' is not safe, as it might return, e.g. a running editor session were something with $APPNAME is edited! Also, some users might want to run two backups simultaneously: rsync-time-backup => DEST1 (oldest PID) rsync-time-backup => DEST2 (2nd oldest PID) In that case, simply comparing the oldest PID of APPNAME with RUNNINGPID will not prevent starting of several instances of the backup to DEST2. Instead one should check, as done for cygwin (some lines above), whether the process currently running under RUNNINGPID is identical with $APPNAME.
This was referenced Aug 14, 2018
|
Pr #129 fixes the same (did not see before, sorry), with less tools and the same way as netbsd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command 'pgrep -o -f "$APPNAME"' is not safe, as it might return,
e.g. a running editor session where something with $APPNAME is edited!
Also, some users might want to run two backups simultaneously:
rsync-time-backup => DEST1 (oldest PID)
rsync-time-backup => DEST2 (2nd oldest PID)
In that case, simply comparing the oldest PID of APPNAME with RUNNINGPID
will not prevent starting of several instances of the backup to DEST2.
Instead one should check, as done for cygwin (some lines above), whether
the process currently running under RUNNINGPID is identical with $APPNAME.