-
Notifications
You must be signed in to change notification settings - Fork 349
ci(lint): clang-format with buf format for protobuf formatting #14538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Co-authored-by: lahabana <[email protected]>
buf format
@copilot please update your PR taking into account my review |
… with make check Co-authored-by: lahabana <[email protected]>
Updated the PR addressing all your review feedback:
|
@copilot can you rereun |
Co-authored-by: lahabana <[email protected]>
Ran Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Signed-off-by: Charly Molter <[email protected]>
I think we also need to update renovate config: Lines 79 to 87 in 2ea5f29
|
should we run |
Why? protoc generates the go files. You can see the go files are unchanged (except the version comments) what else do you expect? |
Co-authored-by: Marcin Skalski <[email protected]> Signed-off-by: Charly Molter <[email protected]> fix renovate ocnfig Signed-off-by: Charly Molter <[email protected]>
3877154
to
ae5196a
Compare
This PR replaces clang-format with
buf format
for protobuf file formatting across the Kuma repository, addressing the pain points with clang-format while providing better protobuf-native tooling.Changes Made
Tool Configuration:
buf.yaml
configuration file with standard formatting and linting rulesmise.toml
to install buf (v1.57.2
) using the buf plugin directly instead of clang-format (13.0.0
)mk/dev.mk
to useBUF
variable instead ofCLANG_FORMAT
Build System:
mk/check.mk
to usebuf format -w
without CI conditionals, since buf should always be availablemake check
workflow instead of standalone GitHub Actions stepGitHub Actions:
clang-format
fromMISE_DISABLE_TOOLS
across all 6 workflow filesbuild-test-distribute.yaml
since formatting is now handled bymake check
Formatting:
api/
,pkg/
, andtest/
directories.pb.go
files usingmake generate/protos
to ensure consistency with the formatted proto filesBenefits
make check
without separate CI stepsThe migration preserves all existing developer workflows while providing a more robust and protobuf-focused formatting solution that's fully integrated with the existing build system.
Fixes #14537.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.