-
Notifications
You must be signed in to change notification settings - Fork 349
✨ Add GitHub Copilot instructions for Kuma repository #14536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Co-authored-by: lahabana <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, but lgtm overall
### Multi-zone/Multi-mesh Complexity | ||
- **Zone configuration**: Test cross-zone functionality carefully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
### Multi-zone/Multi-mesh Complexity | |
- **Zone configuration**: Test cross-zone functionality carefully | |
### Multi-zone/Multi-mesh Complexity | |
- **Zone configuration**: Test cross-zone functionality carefully |
### Build Issues | ||
- **Missing dependencies**: Run `make install` to install dev tools via mise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
### Build Issues | |
- **Missing dependencies**: Run `make install` to install dev tools via mise | |
### Build Issues | |
- **Missing dependencies**: Run `make install` to install dev tools via mise |
### Test Issues | ||
- **Golden file mismatches**: Run `make test UPDATE_GOLDEN_FILES=1` to update expected output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
### Test Issues | |
- **Golden file mismatches**: Run `make test UPDATE_GOLDEN_FILES=1` to update expected output | |
### Test Issues | |
- **Golden file mismatches**: Run `make test UPDATE_GOLDEN_FILES=1` to update expected output |
This PR adds comprehensive GitHub Copilot instructions to help AI coding assistants provide better context-aware assistance when working on the Kuma service mesh codebase.
What's Added
Created
.copilot-instructions.md
with detailed guidance covering:kuma-cp
), data plane (kuma-dp
), CLI (kumactl
), and multi-zone capabilitiesmake check
- code formatting, linting, and validationmake test
- running tests with component-specific variantsmake generate
- code generation for protobuf, resources, and policiesmake test UPDATE_GOLDEN_FILES=1
- updating test golden filespkg/
directory structure and component responsibilitiesBenefits
This will enable GitHub Copilot and other AI coding assistants to:
All commands and patterns referenced in the instructions have been verified against the actual repository structure and Makefile targets.
Fixes #14535.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.