Add validations for explainable model arguments in MimicExplainer #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
imatiach-msft
approved these changes
Dec 31, 2020
| if is_tree_model and self._supports_categoricals(explainable_model): | ||
| # Index the categorical string columns for training data | ||
| self._column_indexer = initialization_examples.string_index(columns=categorical_features) | ||
| self._one_hot_encoder = None |
There was a problem hiding this comment.
why was this removed?
explainable_model_args[LightGBMParams.CATEGORICAL_FEATURE] = categorical_features
There was a problem hiding this comment.
oh I guess you moved it to line 347, I guess that's ok, my only slight concern is now we are doing the same checks in multiple places:
is_tree_model = explainable_model.explainable_model_type == ExplainableModelType.TREE_EXPLAINABLE_MODEL_TYPE
if is_tree_model and self._supports_categoricals(explainable_model):
but it's not expensive so I think it's ok
Signed-off-by: Gaurav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gupta [email protected]