Fix inconsistent topic names in PosePublisher after reset #3220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3116
Summary
What is the issue
PosePublisher generates inconsistent topic names between initial load and world reset:
/model/vehicle/pose/world/demo/model/vehicle/poseWhy it happens
The
topicFromScopedNamefunction recurses over all parents to constitute the topic name. At initial configure, the world parent entity wasn't available yet. After reset, the full entity hierarchy exists, producing a different topic name.Solution
PostUpdate()when the world entity component is guaranteed to exist. This follows the same pattern used inJointStatePublisher._excludeWorldparameter totrueintopicFromScopedName: to consistently exclude the world name from topics, matching the expected topic name and existing behavior.How to reproduce
ros2 launch ros_gz_sim_demos sdf_parser.launch.pygz topic -lshows/model/vehicle/pose/world/demo/model/vehicle/poseAfter this fix, the topic remains
/model/vehicle/posein both cases.Notes
Checklist
codecheckpassed (See contributing)INTEGRATION_examples_buildunrelated to this change)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.