-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add settings that allow for setup for GPU passthru #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passthru device backends can take options such as rom and bootindex. Accept those via passthruX_options settings.
bhyve can be dependent upon the order of the options is receives, so add a setting similar to bhyve_options, called bhyve_extra, that is passed to bhyve as the last options. "-s 31,lpc" is passed by vm-bhyve after the options provided by bhyve_options. However, this causes bhyve to return an error when attempting to use GPU passthru with an Intel iGPU due to additional options needing to be passed. Example: $ bhyve ... -o pci.0.31.0.pcireg.vendor=host -s 31,lpc ... pci slot 0:31:0 already occupied!
What is the difference betweeen |
I think this needs to be split into two PRs... |
The ordering of parameters. |
They can be squashed during the merge or made separate. Either way is fine by me. I had only separated them to see what was being requested. Both were needed, at least at the time, for GPU passthru to work for me. I still need to test these again as I have not tried the passthru for awhile due to other factors. Once I have setup my system and tested it, I will convert this draft to a true PR (or PR's). |
I try to look at this next couple of days including the video again which I have seen already. What one should do is also update the manpage otherwise this will be lost. |
UUIDs and MAC addresses are regenerated during cloning to keep them unique. However, it takes effect on next cold-boot. If the VM is suspended, even if MAC address and UUID are renewed, it resumes with the old MAC address and UUID stores in the memory. This may cause potential conflict, so the VM needs to be stopped before cloning.
STYLE: consider using OS macro: Fx
Same with freebsd#23, localization is not needed here.
My apologies. I messed up the branch, but I will redo it later. |
I am closing this PR in favor of two separate PR's: |
Following the instructions from GPU passthrough with bhyve - Corvin Köhne - EuroBSDcon 2023, a couple of additional settings are needed to pass the proper values and in the correct order:
passthruX_options
: Options given to the passthru device to specifyrom
and/orbootindex
.bhyve_extra
: Options that are passed to bhyve at the end of the command-line.