Avoid having two copies of /boot in mfs iso #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given how critical space is in mfsroot, it seems to make sense to avoid having a copy of /boot in the mfsroot since it's in the ISO anyway and that's the one that's used for boot, not the copy in mfsroot.
|
While I do agree with the approach, I disagree with the fact of removing entirely the modules. one can have a kld_list in the rc.conf so I do think we should keep the modules and nuke the kernel itself and all other files. |
|
I agree. Perhaps it would be good to have a separate flag for this? I've also run into cases where I need to customize the boot, such as creating /boot.config or modifying /boot/device.hints. Perhaps a separate root for the iso contents vs the mfsroot would make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given how critical space is in mfsroot, it seems to make sense to avoid
having a copy of /boot in the mfsroot since it's in the ISO anyway and
that's the one that's used for boot, not the copy in mfsroot.