Add overlays to the jail command #1241
Open
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only reason these checks failed is: Monthly compute limit exceeded! |
michael-o
reviewed
Aug 28, 2025
| Options for -s and -k: | ||
| -p tree -- Specify which ports tree to start/stop the jail with. | ||
| -O overlays -- Specify extra ports trees to overlay. |
There was a problem hiding this comment.
manpage says overlay, here overlays...
There was a problem hiding this comment.
I have follow the same schema as in case of bulk:
poudriere/src/man/poudriere-bulk.8
Line 306 in 544d112
poudriere/src/share/poudriere/bulk.sh
Line 66 in 544d112
I guess we can change here and in bulk option to -O overlay
There was a problem hiding this comment.
Oh, I see. It should be clear that -O can be invoked multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a missing option for running a reference jail when working with overlays.
We have all the required utilities. We just need to pass the information about the overlays.