Drop some Qt patches #441
Open
Drop some Qt patches #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to avoid undefined references during linking with -Wl,-no-undefined See https://reviews.freebsd.org/D30842
This allows to avoid undefined references during linking with -Wl,-no-undefined Note that the similar patch for www/chromium is not required because the extern char** environ usage ends up in the executable, not a library. See https://reviews.freebsd.org/D30842
It was added to workaround the "extern char** environ" problem [1], which is now fixed in other way. [1] https://reviews.freebsd.org/D30842
|
Looks good to me, but I doubt I will have time to run test with Qt 6.9.x. I'll test with 6.10 after I hammer that out, though. Upstream might skip 6.9.3, so I don't want to spend too much more time on 6.9, but if it works for you, I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BSDKaffee I tested this up to compiling
www/falkon. Did not run-test this, though.