Uses/cargo: use --locked flag on install #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The litellm change would require an approval from @tagattie |
|
I pushed an update to py-litellm a while ago though it seems unrelated to the proposed change to cargo.mk 😄 |
Yeah, sry for that noise. I guess the commit slipped in because the github mirror hasn't synced yet. |
By default cargo install ignores the lock file [1]. This will cause our build to fail easily. First of all, when building with tools like poudriere, network access will be disabled in install stage. Fetching a new crate won't be possible. Additionally, a newer crate version might be incompatible with our crate or even more worse unbuildable at all. For that reason, force cargo to honor the lock file on install. [1] https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile Sponsored by: Beckhoff Automation GmbH & Co. KG
ckoehne
force-pushed
the
phab/corvink/cargo-locked
branch
from
0f96876 to
1794870
Compare
|
Sounds reasonable to me but please create a PR in bugzilla |
|
Well, it might feel reasonable, but it has to be possible to disable that knob, crates gets pulled, and lock files become unusable. |
|
salewski
pushed a commit
to salewski/freebsd-ports
that referenced
this pull request
May 22, 2025
Major changes between sudo 1.9.16p1 and 1.9.16: * Fixed the test for cross-compiling when checking for C99 snprintf(). The changes made to the test in sudo 1.9.16 resulted in a different problem. GitHub issue freebsd#386. * Fixed the date used by the exit record in sudo-format log files. This was a regression introduced in sudo 1.9.16 and only affected file-based logs, not syslog. GitHub issue freebsd#405. * Fixed the root cause of the "unable to find terminal name for device" message when running sudo on AIX when no terminal is present. In sudo 1.9.16 this was turned from a debug message into a warning. GitHub issue freebsd#408. * When a duplicate alias is found in the sudoers file, the warning message now includes the file and line number of the previous definition. * Added support for the --with-secure-path-value=no configure option to allow packagers to ship the default sudoers file with the secure path line commented out. * Sudo no longer sends mail when a user runs "sudo -nv" or "sudo -nl", even if "mail_badpass" or "mail_always" are set. Sudo already avoids logging to a file or syslog in this case. Bug #1072. PR: 282720 Approved by: garga (maintainer) MFH: 2024Q4 (cherry picked from commit 26f5b17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default cargo install ignores the lock file [1]. This will cause our
build to fail easily. First of all, when building with tools like
poudriere, network access will be disabled in install stage. Fetching a
new crate won't be possible. Additionally, a newer crate version might
be incompatible with our crate or even more worse unbuildable at all.
For that reason, force cargo to honor the lock file on install.
[1] https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile
Sponsored by: Beckhoff Automation GmbH & Co. KG