Fix: Update Kavita initContainer to use appsettings.json #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modifies the Kavita init container logic to create/check for `appsettings.json` instead of `config.xml`. - Sets the `BaseUrl` property in `appsettings.json` using the `$(KAVITA)` placeholder to allow runtime configuration via the KAVITA environment variable. - Applied changes to `base/kavita/deployment.yaml`, `install_armhf.yaml`, and `install_x86_64.yaml`.
- Modifies the Kavita init container logic to create/check for `appsettings.json` instead of `config.xml`. - Sets the `BaseUrl` property in `appsettings.json` to `"/$(KAVITA)"`, ensuring the leading forward slash is present and allowing runtime configuration via the KAVITA environment variable. - Applied changes to `base/kavita/deployment.yaml`, `install_armhf.yaml`, and `install_x86_64.yaml`.
Corrects the indentation of the multi-line shell script in the `args` field of the Kavita init container configuration in `base/kavita/deployment.yaml`. This resolves a YAML parsing error that occurred due to incorrect indentation after previous modifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appsettings.jsoninstead ofconfig.xml.BaseUrlproperty inappsettings.jsonusing the$(KAVITA)placeholder to allow runtime configuration via the KAVITA environment variable.base/kavita/deployment.yaml,install_armhf.yaml, andinstall_x86_64.yaml.