Skip to content

Conversation

fabito
Copy link
Owner

@fabito fabito commented Apr 27, 2025

No description provided.

@fabito fabito added the enhancement New feature or request label Apr 27, 2025
@fabito fabito requested a review from Copilot April 27, 2025 01:14
@fabito fabito self-assigned this Apr 27, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for Readarr by adding its deployment, service, and related configuration changes to both overlay and base manifests. Key changes include:

  • Adding Readarr image and tag updates to kustomization files
  • Creating new service and deployment definitions for Readarr in x86 and armhf installation manifests
  • Integrating Readarr into base kustomize resources and patches

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
overlays/x86/kustomization.yaml Added Readarr image details
install_x86_64.yaml & install_armhf.yaml New service and deployment definitions for Readarr
base/volumes_patch.yaml Added volume configuration and an unexpected new deployment block
base/readarr/{service,deployment,kustomization.yaml} Introduced Readarr base resources with related configurations
base/kustomization.yaml Included Readarr in the kustomize resource list and variable setup
base/ingress-route.yaml Added a new ingress rule for Readarr
Comments suppressed due to low confidence (1)

base/volumes_patch.yaml:92

  • A new Deployment 'readarr' is being defined in a patch file, which is unconventional. Consider removing this definition and applying patch modifications to the existing Readarr deployment instead.
apiVersion: apps/v1

@fabito fabito merged commit bb77d7f into master Apr 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant