Make row/column/value field selection more robust #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gizmoguy
changed the title
gizmoguy
force-pushed
the
field-selection
branch
from
f2f7cf7 to
05d1fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few different bugs with field selection for row names, column names and values.
Currently if a field is selected to use as the row/column names, but the field doesn't actually exist in the dataframe, this exception will occur:
If the static row/column name option is enabled but no row or column names are provided, this exception will occur:
I have also moved the row/column/value options to use the grafana-ui native FieldNamePicker, and updated the field selection logic in dataParser.ts to add support for renamed data fields (by changing the data source display name or using a transformation).
This fixes #17
This fixes #8