improve error handling, buffer operations, and TypeScript configurat… #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CluEleSsUK
reviewed
May 14, 2025
| } | ||
|
|
||
| throw new Error(`Unsupported beacon type: ${chainInfo.schemeID}`); | ||
| } catch (error) { |
There was a problem hiding this comment.
catching locally thrown errors feels like a bit of a code smell. Also this could be a breaking change for users expecting certain cryptographic errors to throw exceptions
CluEleSsUK
reviewed
May 14, 2025
| const buffer = Buffer.alloc(8) | ||
| buffer.writeBigUInt64BE(BigInt(round)) | ||
| return buffer | ||
| if (!Number.isInteger(round) || round < 0) { |
There was a problem hiding this comment.
the check here makes sense, though I dunno the rationale behind replacing writeBigUint64BE
CluEleSsUK
reviewed
May 14, 2025
| if (!!this.options.chainVerificationParams && !isValidInfo(chainInfo, this.options.chainVerificationParams)) { | ||
| throw Error(`The chain info retrieved from ${this.baseUrl} did not match the verification params!`) | ||
| async get(roundNumber: number): Promise<RandomnessBeacon> { | ||
| if (!Number.isInteger(roundNumber) || roundNumber < 1) { |
There was a problem hiding this comment.
we actually accept 0 too though it returns latest
CluEleSsUK
reviewed
May 14, 2025
| roundNumber = roundAt(Date.now(), info); | ||
| } | ||
|
|
||
| if (roundNumber < 1) { |
There was a problem hiding this comment.
hmm although the old code didn't accept it 🤔
CluEleSsUK
reviewed
May 14, 2025
| @@ -6,64 +6,107 @@ import {LIB_VERSION} from './version' | |||
|
|
|||
| export function sleep(timeMs: number): Promise<void> { | |||
| return new Promise(resolve => { | |||
| if (!Number.isFinite(timeMs)) { | |||
There was a problem hiding this comment.
bit of a random change - this is only used a few places in the lib itself, none of which take Infinity afaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Improve SDK stability with enhanced error handling, BigInt buffer fixes, and TypeScript updates
improved error handling for more robust runtime behavior.
Fixed buffer operations involving BigInt to ensure accurate processing.
Updated TypeScript configuration to strengthen type safety and developer experience.
Enhanced beacon verification logic for better reliability and correctne