Skip to content

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 15, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.42%. Comparing base (8398538) to head (00b37ce).

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 20.00% 8 Missing ⚠️
rust/cubesql/cubesql/src/transport/service.rs 37.50% 5 Missing ⚠️
...t/cubesql/cubeclient/src/models/v1_load_request.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9972      +/-   ##
==========================================
- Coverage   83.44%   83.42%   -0.02%     
==========================================
  Files         254      254              
  Lines       75091    75121      +30     
==========================================
+ Hits        62660    62673      +13     
- Misses      12431    12448      +17     
Flag Coverage Δ
cubesql 83.42% <43.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the feat/cubesql-cache-options branch 3 times, most recently from bb98d78 to 2c625cf Compare September 17, 2025 09:48
@KSDaemon KSDaemon marked this pull request as ready for review September 17, 2025 10:23
@KSDaemon KSDaemon requested review from a team as code owners September 17, 2025 10:23
@igorlukanin
Copy link
Member

@KSDaemon Should we document what each option is supposed to do in the code? I feel like it might get lost in Jira/docs at some point 😄

@KSDaemon
Copy link
Member Author

Well, why not...

@KSDaemon KSDaemon force-pushed the feat/cubesql-cache-options branch 8 times, most recently from 23756a8 to 1af974a Compare September 18, 2025 13:11
@KSDaemon KSDaemon force-pushed the feat/cubesql-cache-options branch from e2f1742 to b53ae15 Compare September 25, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants