feat: guardian and guardian_ninja schemas #34
+1,022
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GuilhermePSF
commented
Aug 21, 2025
GuilhermePSF
commented
- closes Create guardian and guardian_ninja schemas #33
ruilopesm
reviewed
Sep 3, 2025
| @@ -0,0 +1,104 @@ | |||
| defmodule Katana.GuardiansNinjas do | |||
There was a problem hiding this comment.
We should avoid creating a context per entity. Read more about contexts and how to use them here.
There was a problem hiding this comment.
What type or architecture should we adapt? What entities go in which context?
|
Please make it clear on each PR (you can use the description) which dependencies does it have. For example, this one depends on #31 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.