tetragon: Fix TestControllerSuite flake panic #4110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
olsajiri
added
the
release-note/minor
When we hit error (flake?) in TestControllerSuite we panic like below:
panic.go:262: test panicked: runtime error: invalid memory address or nil pointer dereference
goroutine 69 [running]:
runtime/debug.Stack()
/opt/hostedtoolcache/go/1.25.1/x64/src/runtime/debug/stack.go:26 +0x5e
github.com/stretchr/testify/suite.failOnPanic(0xc000670700, {0x1bd1700, 0x314f770})
/home/runner/work/tetragon/tetragon/vendor/github.com/stretchr/testify/suite/suite.go:89 +0x37
github.com/stretchr/testify/suite.Run.func1.1()
/home/runner/work/tetragon/tetragon/vendor/github.com/stretchr/testify/suite/suite.go:184 +0x25f
panic({0x1bd1700?, 0x314f770?})
/opt/hostedtoolcache/go/1.25.1/x64/src/runtime/panic.go:783 +0x132
github.com/cilium/tetragon/pkg/manager.(*ManagerTestSuite).TestFindContainer(0xc0004a6e10)
/home/runner/work/tetragon/tetragon/pkg/manager/manager_integration_test.go:108 +0x2b9
reflect.Value.call({0xc0000b0e80?, 0xc00008acb8?, 0x1931bc5?}, {0x1e8196e, 0x4}, {0xc000096f28, 0x1, 0x1be6680?})
/opt/hostedtoolcache/go/1.25.1/x64/src/reflect/value.go:581 +0xcc6
reflect.Value.Call({0xc0000b0e80?, 0xc00008acb8?, 0x2b90fb8?}, {0xc000096f28?, 0x1cf6680?, 0x218f401?})
/opt/hostedtoolcache/go/1.25.1/x64/src/reflect/value.go:365 +0xb9
github.com/stretchr/testify/suite.Run.func1(0xc000670700)
/home/runner/work/tetragon/tetragon/vendor/github.com/stretchr/testify/suite/suite.go:196 +0x425
testing.tRunner(0xc000670700, 0xc00014e120)
/opt/hostedtoolcache/go/1.25.1/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 28
/opt/hostedtoolcache/go/1.25.1/x64/src/testing/testing.go:1997 +0x465
Make sure we do not panic in case suite.manager.FindContainer fails.
Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
24664f2 to
57d8ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we hit error (flake?) in TestControllerSuite we panic like below:
Make sure we do not panic in case suite.manager.FindContainer fails.
Fixes
Description
Changelog