Dual network filter #1413
Draft
Dual network filter #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
force-pushed
the
dual-network-filter
branch
8 times, most recently
from
edcd478 to
97d5ad6
Compare
Signed-off-by: Jarno Rajahalme <[email protected]>
Use 'empty' method when checking if a string is empty or not instead of comparing 'length'. This makes the code a bit more readable. Signed-off-by: Jarno Rajahalme <[email protected]>
Skip HTTP policy enforcement if no HTTP rules and the last policy lookup was with the same policy version, remote identity and port. This prepares for the next commit that makes network policy enforcement only happen when new connection is created, rather than on each request. Signed-off-by: Jarno Rajahalme <[email protected]>
Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
dual-network-filter
branch
from
97d5ad6 to
c7a303e
Compare
Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
dual-network-filter
branch
5 times, most recently
from
0422d61 to
23b6d0b
Compare
Pass connection close from upstream response to downstream response when upstream and downstream connections have the same 5-tuple. This helps avoid connection freeze due to 5-tuple conflict. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
dual-network-filter
branch
from
23b6d0b to
d6b4059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the network filter upstream callback patch with a new one that adds an upstream/read filter callback
onDestinationSelected(). This is called before a new upstream connection is attempted to give chance for the network policy to deny making the new connection. The connection-level local reset is translated to a newaccess_deniedstream reset reason, which in turn is translated to the HTTP response code403.This new read filter callback is only called for new connections, and not for each HTTP request like the old one. This makes it necessary to revert the recent change to not perform HTTP policy enforcement on requests if policy did not have any HTTP rules. With this change the HTTP policy enforcement is always made, as the policy may have changed since the network policy enforcement was done, even if there are no HTTP rules.
A second Envoy patch is added for backwards compatibility to call the new callback on the downstream filter chain if no upstream filters respond to it. This patch can be removed once the oldest supported Cilium release installs the upstream Cilium network filter.