Skip to content

Conversation

yashisrani
Copy link

@yashisrani yashisrani commented Sep 16, 2025

fix: #773

Description:

  • This PR improves the Makefile for the Cilium website by:

    • Adding an env target to safely copy .env.example to .env.
    • Introducing start (lightweight dev) and start-full (full dev) targets.
    • Adding Docker targets: docker-build, docker-run, docker-run-dev, and docker-shell.
    • Including linting, formatting, and reinstall targets for easier local setup.
  • These changes simplify contributor setup, reduce CPU load during development, and standardize Docker workflows.

How to use:

make env           # create .env if missing
make start         # start lightweight dev server
make start-full    # start full dev server (images processed)
make build         # production build
make serve         # serve production build locally
make docker-build  # build Docker image
make docker-run    # run production Docker container
make docker-run-dev # run dev environment in Docker

Copy link

netlify bot commented Sep 16, 2025

👷 Deploy Preview for cilium processing.

Name Link
🔨 Latest commit f5c553c
🔍 Latest deploy log https://app.netlify.com/projects/cilium/deploys/68c99ba2b5046c0007609eef

Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for cilium ready!

Name Link
🔨 Latest commit afa4b97
🔍 Latest deploy log https://app.netlify.com/projects/cilium/deploys/68caceaf63998d0008f58e85
😎 Deploy Preview https://deploy-preview-772--cilium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xmulligan xmulligan requested a review from paularah September 17, 2025 05:30
@paularah
Copy link
Contributor

@yashisrani You should add a corresponding note in the README on how to use the makefile.

@paularah
Copy link
Contributor

in the getting started section of README, add a note that says something along the lines of: "There's a makefile with all the dev commands, you can set the project using make dev, make env & make start.

@yashisrani
Copy link
Author

@paularah Do you want me to also remove the raw npm commands (to avoid duplication), or should we keep both for flexibility?

@paularah
Copy link
Contributor

Keep both. I'll add a small sidenote for the dev commands.

Signed-off-by: Yash Israni <[email protected]>
@paularah
Copy link
Contributor

Thanks for the PR!

@yashisrani yashisrani requested a review from paularah September 18, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Makefile for Cilium website development and Docker workflow
3 participants