-
Notifications
You must be signed in to change notification settings - Fork 29
chore: vulnerability scanning updates #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iFergal
wants to merge
8
commits into
develop
Choose a base branch
from
chore/deps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a707057
chore: ignore mostly irrelevant vulnerabilities for now and remove un…
iFergal 47e5164
chore(cred-serv): audit fixes
iFergal d3527fc
chore: update ignore list for osv scanner
iFergal 9d7c5fb
chore(gha/depcheck): ignore osv-scanner dev depends until end of 01/2…
rcmorano a8683de
chore(gha/depcheck-owasp): added owasp depcheck for package[-lock].json
rcmorano aa509fd
chore(gha/depcheck-owasp): changed android specific job to scan any j…
rcmorano 6cefd41
chore(gha/depcheck-owasp): changed ios specific job to check Podfile.…
rcmorano d49baae
chore(gha/depcheck-owasp): change android job to only look into jar f…
rcmorano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| name: dependency-check-owasp-package-json | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: &shared-trigger-paths | ||
| - 'package.json' | ||
| - 'package-lock.json' | ||
| - '.github/workflows/dependency-check-owasp.yaml' | ||
| types: [ opened, synchronize ] | ||
| push: | ||
| paths: *shared-trigger-paths | ||
| branches: | ||
| - main | ||
| - develop | ||
| - release/** | ||
|
|
||
| jobs: | ||
| depcheck: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
|
|
||
| env: | ||
| NVD_API_KEY: ${{ secrets.NVD_API_KEY }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
|
||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
|
||
| with: | ||
| node-version-file: "package.json" | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| # Run OWASP Dependency-Check via the official Action | ||
| - name: Run Dependency-Check | ||
| uses: dependency-check/Dependency-Check_Action@2ba636726705b0f74f126ebeaacaf2ad4600b967 # main at 01/10/2025 | ||
| with: | ||
| project: "veridian-wallet" | ||
| path: "." | ||
| format: "ALL" | ||
| out: "reports" | ||
| args: "--failOnCVSS 7 --nvdApiKey ${{ env.NVD_API_KEY }} -s **/package*json" | ||
| continue-on-error: false | ||
|
|
||
| - name: Upload HTML report | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| if: always() | ||
| with: | ||
| name: depcheck-android-report | ||
| path: "./dependency-check-report.html" | ||
|
|
||
| - name: Upload SARIF to code scanning | ||
| uses: github/codeql-action/upload-sarif@3599b3baa15b485a2e49ef411a7a4bb2452e7f93 # v3.30.5 | ||
| if: always() | ||
| with: | ||
| sarif_file: "reports/dependency-check-report.sarif" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,17 @@ | ||
| { | ||
| // $schema provides code completion hints to IDEs. | ||
| "$schema": "https://github.com/IBM/audit-ci/raw/main/docs/schema.json", | ||
| "moderate": false, | ||
| "critical": true, | ||
| "low": true, | ||
| "allowlist": [ | ||
| "GHSA-fjxv-7rqg-78g4", | ||
| { | ||
| "1100267": { | ||
| "active": true, | ||
| "notes": "This is a ReDOS vulnerability for email inputs in Appium drivers, so not applicable." | ||
| }, | ||
| "1101851": { | ||
| "active": true, | ||
| "notes": "SSRF attacks are not relevant to our usage of Meerkat." | ||
| }, | ||
| "1103618": { | ||
| "active": true, | ||
| "notes": "SSRF attacks on the Appium server when e2e testing do not impact the wallet." | ||
| }, | ||
| "1105443": { | ||
| "active": true, | ||
| "notes": "REDS attacks on @capacitor/assets and the Appium server when e2e testing do not impact the wallet." | ||
| }, | ||
| "1105444": { | ||
| "active": true, | ||
| "notes": "REDS attacks on @capacitor/assets and the Appium server when e2e testing do not impact the wallet." | ||
| }, | ||
| "1106812": { | ||
| "active": true, | ||
| "notes": "On-headers is vulnerable to http response header on Appium server do not impact the wallet." | ||
| }, | ||
| "1106507": { | ||
| "active": true, | ||
| "notes": "form-data uses Math.random() to select a boundary value for multipart form-encoded data. A hacker Can observe values produced by Math.random in the application and control the field of a form-data request on Appium server do not impact the wallet." | ||
| }, | ||
| "1106849": { | ||
| "active": true, | ||
| "notes": "tmp allows arbitrary temporary file / directory write via symbolic link `dir` parameter" | ||
| } | ||
| } | ||
| "GHSA-2p57-rm9w-gvfp", // SSRF attacks not relevant to our usage of Meerkat | ||
| "GHSA-4hjh-wcwx-xvwj", // e2e tests | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I intend on re-evaluating some of these properly in case they pose some risk, even if a dev dependency. But I think it's easier to just blanket update appium and all related e2e dependencies tomorrow. |
||
| "GHSA-52f5-9888-hmc6", // e2e tests | ||
| "GHSA-5j98-mcp5-4vw2", // e2e tests | ||
| "GHSA-76c9-3jph-rj3q", // e2e tests | ||
| "GHSA-fjxv-7rqg-78g4", // e2e tests | ||
| "GHSA-jr5f-v2jv-69x6", // e2e tests | ||
| "GHSA-mh29-5h37-fv8m", // Only reads our config or jest/eslint related so little to no risk | ||
| "GHSA-rv73-9c8w-jp4c", // e2e tests | ||
| "GHSA-v6h2-p8h4-qcjw" // e2e tests or linting - low risk | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,48 @@ | ||
| [[IgnoredVulns]] | ||
| id = "GHSA-2p57-rm9w-gvfp" | ||
| reason = "pkg: ip - npte: no fix available yet" | ||
| ignoreUntil = 2025-10-31 # lets review it at this date | ||
| reason = "pkg: ip - note: SSRF attacks not relevant to our usage of Meerkat" | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-4hjh-wcwx-xvwj" | ||
| reason = "pkg: axiox (dev) - note: used in e2e tests" | ||
| reason = "pkg: axiox (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-52f5-9888-hmc6" | ||
| reason = "pkg: tmp (dev) - note: used by cucumber" | ||
| # | ||
| # ├─────────────────────────────────────┼──────┼───────────┼───────────────────┼─────────┼───────────────┼───────────────────────┤ | ||
| # │ https://osv.dev/GHSA-v6h2-p8h4-qcjw │ 3.1 │ npm │ brace-expansion │ 1.1.11 │ 1.1.12 │ src/package-lock.json │ | ||
| # │ https://osv.dev/GHSA-v6h2-p8h4-qcjw │ 3.1 │ npm │ brace-expansion │ 2.0.1 │ 2.0.2 │ src/package-lock.json │ | ||
| # │ https://osv.dev/GHSA-fjxv-7rqg-78g4 │ 9.4 │ npm │ form-data (dev) │ 4.0.2 │ 4.0.4 │ src/package-lock.json │ | ||
| # │ https://osv.dev/GHSA-76c9-3jph-rj3q │ 3.4 │ npm │ on-headers (dev) │ 1.0.2 │ 1.1.0 │ src/package-lock.json │ | ||
| # │ https://osv.dev/GHSA-95m3-7q98-8xr5 │ 9.1 │ npm │ sha.js (dev) │ 2.4.11 │ 2.4.12 │ src/package-lock.json │ | ||
| # │ https://osv.dev/GHSA-rv73-9c8w-jp4c │ 6.6 │ npm │ validate.js (dev) │ 0.13.1 │ -- │ src/package-lock.json │ | ||
| # ╰─────────────────────────────────────┴──────┴───────────┴───────────────────┴─────────┴───────────────┴───────────────────────╯ | ||
| reason = "pkg: tmp (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-jr5f-v2jv-69x6" | ||
| reason = "pkg: axios (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-v6h2-p8h4-qcjw" | ||
| reason = "pkg: brace-expansion (dev) - note: e2e tests or linting - low risk" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-fjxv-7rqg-78g4" | ||
| reason = "pkg: form-data (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-5j98-mcp5-4vw2" | ||
| reason = "pkg: glob (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-mh29-5h37-fv8m" | ||
| reason = "pkg: js-yaml (dev) - note: Only reads our config or jest/eslint related so little to no risk" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-76c9-3jph-rj3q" | ||
| reason = "pkg: on-headers (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "GHSA-rv73-9c8w-jp4c" | ||
| reason = "pkg: validate.js (dev) - note: e2e tests" | ||
| ignoreUntil = 2026-01-31 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.