Skip to content

fix: bug in time limited v2 credential idempotency check #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
evq wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: bug in time limited v2 credential idempotency check #2945

evq wants to merge 1 commit into from
+11 −10

Conversation

@evq
Copy link
Contributor

@evq evq commented Oct 31, 2025

Summary

fixes https://github.com/brave/premium-support/issues/45

opening as a draft for now until we find time to test it.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clD11 clD11 Awaiting requested review from clD11 clD11 will be requested when the pull request is marked ready for review clD11 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evq