bugfix: mvn spotless:apply failed #7644
Open
+8
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. @xingfudeshi Thank you for changing the Chinese phrase. |
No worries. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7644 +/- ##
============================================
- Coverage 61.05% 60.99% -0.06%
+ Complexity 670 666 -4
============================================
Files 1316 1316
Lines 49804 49804
Branches 5855 5855
============================================
- Hits 30407 30378 -29
- Misses 16689 16714 +25
- Partials 2708 2712 +4
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
jongmin-chung
force-pushed
the
bugfix/spotless_apply_java25
branch
from
354a075 to
e1518f1
Compare
jongmin-chung
commented
Sep 18, 2025
| case TimeoutRollbacked: | ||
| case Rollbacked: | ||
| // rollback transactions but do not exist are usually considered completed | ||
| // rollback transactions but do not exist are usually considered completed |
There was a problem hiding this comment.
In Java 11, this comment should be indented, but not indented in Java17, Java25, which is a problem.
There was a problem hiding this comment.
In Java 11, this comment should be indented, but not indented in Java17, Java25, which is a problem.
Yes — with your current changes, everything for Java11 and above should now follow the same coding style, right?
There was a problem hiding this comment.
Java 11 (Has Error ❌)
$ sdk use java 11.0.27-librca
$ ./mvnw spotless:check
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations:
[ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java
[ERROR] @@ -290,7 +290,7 @@
[ERROR] ················break;
[ERROR] ············case·TimeoutRollbacked:
[ERROR] ············case·Rollbacked:
[ERROR] -············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR] +················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR] ············case·Finished:
[ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone;
[ERROR] ················break;
[ERROR] Run 'mvn spotless:apply' to fix these violations.Java 17 and above (✅)
$ sdk use java 17.0.16-librca (java 21, java 25 OK)
$ ./mvnw spotless:check
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations:
[ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java
[ERROR] @@ -290,7 +290,7 @@
[ERROR] ················break;
[ERROR] ············case·TimeoutRollbacked:
[ERROR] ············case·Rollbacked:
[ERROR] -················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR] +············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR] ············case·Finished:
[ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone;
[ERROR] ················break;
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :seata-tmThis is the situation above, so there's no problem starting with Java 17 or later.
I have a problem with Java 11. And this happens unconditionally because the position of the comment changes.
What should I do in this situation? (In CI, Java 17 is set, so there is no problem.)
There was a problem hiding this comment.
Java 11 (Has Error ❌)
$ sdk use java 11.0.27-librca $ ./mvnw spotless:check [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations: [ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java [ERROR] @@ -290,7 +290,7 @@ [ERROR] ················break; [ERROR] ············case·TimeoutRollbacked: [ERROR] ············case·Rollbacked: [ERROR] -············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] +················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] ············case·Finished: [ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone; [ERROR] ················break; [ERROR] Run 'mvn spotless:apply' to fix these violations.Java 17 and above (✅)
$ sdk use java 17.0.16-librca (java 21, java 25 OK) $ ./mvnw spotless:check [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on project seata-tm: The following files had format violations: [ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java [ERROR] @@ -290,7 +290,7 @@ [ERROR] ················break; [ERROR] ············case·TimeoutRollbacked: [ERROR] ············case·Rollbacked: [ERROR] -················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] +············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed [ERROR] ············case·Finished: [ERROR] ················code·=·TransactionalExecutor.Code.RollbackDone; [ERROR] ················break; [ERROR] Run 'mvn spotless:apply' to fix these violations. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <args> -rf :seata-tmThis is the situation above, so there's no problem starting with Java 17 or later.
I have a problem with Java 11. And this happens unconditionally because the position of the comment changes.
What should I do in this situation? (In CI, Java 17 is set, so there is no problem.)
Have you consulted the Spotless community about how to resolve this issue?
YongGoose
reviewed
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes: #7640
Ⅲ. Why don't you add test cases (unit test/integration test)?
Just Maven Spoltess applied
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews