Skip to content

Use main thread for FlowCatalog -> listeners.onAddSpec #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use main thread for FlowCatalog -> listeners.onAddSpec #4120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0351e49
Use main thread for FlowCatalog -> listeners.onAddSpec
Jul 3, 2025
15c70c8
Merge branch 'apache:master' into fix-flow-catalog-listeners
thisisArjit Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
import com.google.common.util.concurrent.AbstractIdleService;
import com.google.common.util.concurrent.MoreExecutors;
import com.typesafe.config.Config;
import com.typesafe.config.ConfigException;

Expand Down Expand Up @@ -110,7 +111,7 @@ public FlowCatalog(Config config, GobblinInstanceEnvironment env) {

public FlowCatalog(Config config, Optional<Logger> log, Optional<MetricContext> parentMetricContext, boolean instrumentationEnabled) {
this.log = log.isPresent() ? log.get() : LoggerFactory.getLogger(getClass());
this.listeners = new SpecCatalogListenersList(log);
this.listeners = new SpecCatalogListenersList(Optional.of(MoreExecutors.newDirectExecutorService()), log);
if (instrumentationEnabled) {
MetricContext realParentCtx =
parentMetricContext.or(Instrumented.getMetricContext(new org.apache.gobblin.configuration.State(), getClass()));
Expand Down
6 changes: 5 additions & 1 deletion ...ntime/src/main/java/org/apache/gobblin/runtime/spec_catalog/SpecCatalogListenersList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ public SpecCatalogListenersList() {
}

public SpecCatalogListenersList(Optional<Logger> log) {
_disp = new CallbacksDispatcher<>(Optional.<ExecutorService>absent(), log);
this(Optional.<ExecutorService>absent(), log);
}

public SpecCatalogListenersList(Optional<ExecutorService> executorService, Optional<Logger> log) {
_disp = new CallbacksDispatcher<>(executorService, log);
}

public Logger getLog() {
Expand Down