Fix 3443 to set appropriate httpstatus codes and messages for different types of BlockException #3444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sentinel-adapter/sentinel-spring-webmvc-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/spring/webmvc/AbstractSentinelInterceptor.java # sentinel-demo/sentinel-demo-spring-webmvc/src/main/java/com/alibaba/csp/sentinel/demo/spring/webmvc/config/InterceptorConfig.java
2. improve based on review comments
…e of BlockException.
Linzyoo
changed the title
2. add the Sentinel Exception Aware for webmvc-v6x-adapter.
|
Maintaining consistency in the exceptions DefaultBlockExceptionHandler throws is advisable. In typical use cases, users uniformly handle traffic control exceptions from Sentinel (notably AuthorityException, which serves as an edge case not central to Sentinel's core functionality). Recommended practices suggest allowing users to implement their own BlockExceptionHandler interface to clearly differentiate these exceptions during implementation. |
LearningGp
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR is to update DefaultExceptionHandler with appropriate httpstatus code and message for different types of BlockException.
Does this pull request fix one issue?
Fixes #3443
Describe how you did it
Create an enum for all BlockException and set appropriate httpstatus code and message.
Describe how to verify it
Add test cases for DefaultExceptionHandler
Special notes for reviews