Skip to content

Conversation

@Under-estimate
Copy link

Yes Steve Model plays attack animation according to the handSwinging variable. Updating it in startUpswing makes the animation work properly.

Relevant issue: #385

comparison.mp4

Yes Steve Model plays attack animation according to handSwinging variable. Updating it in startUpswing makes the animation work properly.
@Buubu15
Copy link

Buubu15 commented Oct 13, 2025

Can you help me please, I went to the mod's github page and searched for "startUpswing" but I can't find "player.handSwinging" anymore.
Screenshot (49)

@ZsoltMolnarrr
Copy link
Owner

Thank you for the contribution!

This PR is targeting an old game version, whichI have no longer have an active workspace installation of.

The changes look minimal, yet non intuitive.

I would need to spend a decent amount of time to understand whats going on, why this fix works at all, and test all features on all supported platforms.

I don't know when I will have the capacity for this.

@Under-estimate
Copy link
Author

Thanks for the review! I actually came up with the fix after doing some research on Yes Steve Model. It appears that they directly use these variables for playing hand swing animations. I hope this can provide a better understanding of the changes.

Untitled

@DenisShmyrev
Copy link

Is there a possibility to disable YSM body render?
Cuz when swinging with this mod, in FPV - I can see Models Body.

@TartaricAcid
Copy link

I've directly added this compatibility feature with Better Combat to YSM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants