fix: correct weapon type classifications in itemTypes.json #805
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -903,6 +903,38 @@ | |
| "id": "Pistol", | ||
| "name": "Pistol" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/Secondaries/", | ||
| "name": "Pistol" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/VoidTrader/VTDetron", | ||
| "name": "Pistol" | ||
| }, | ||
|
Comment on lines
+910
to
+913
Member
There was a problem hiding this comment. Detron should be classified as a shotgun or as a pistol? https://wiki.warframe.com/w/Detron https://wiki.warframe.com/w/Mara_Detron |
||
| { | ||
| "id": "/Lotus/Weapons/MK1Series/MK1Furis", | ||
| "name": "Pistol" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/MK1Series/MK1Kunai", | ||
| "name": "Throwing" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/Grimoire/TnDoppelgangerGrimoire", | ||
| "name": "Pistol" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/Grimoire/TnGrimoire", | ||
| "name": "Pistol" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Thanotech/EntratiWristGun/EntratiWristGunWeapon", | ||
| "name": "Pistol" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/LongGuns/GrineerAssaultRifle/TwinGrakatas", | ||
| "name": "Dual Pistols" | ||
| }, | ||
| { | ||
| "id": "/ZanukaPets/ZanukaPetPrecepts", | ||
| "name": "Companion Mod" | ||
|
|
@@ -932,9 +964,150 @@ | |
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeStrun/PrimeStrunWeapon", | ||
| "name": "Shotgun" | ||
| }, | ||
Reuzehagel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Hek/KuvaHekWeapon", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Sobek/KuvaSobek", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Drakgoon/KuvaDrakgoon", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Kohm/KuvaKohm", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Syndicates/SteelMeridian/LongGuns/SMHek", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/LongGuns/GrineerFlakCannon/FlakCannon", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/LongGuns/GrnSpark/GrnSparkRifle", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Syndicates/NewLoka/LongGuns/NLTigris", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeTigris/PrimeTigris", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeAstilla/AstillaPrimeWeapon", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeCorinth/PrimeCorinth", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeCedo/PrimeCedoWeapon", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Corpus/BoardExec/Primary/CrpBEArcaPlasmor/CrpBEArcaPlasmor", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/MK1Series/MK1Strun", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/MK1Series/MK1Paris", | ||
| "name": "Bow" | ||
| }, | ||
| { | ||
| "id": "/(Tenno|Grineer|Corpus)/Bows?", | ||
| "regex": true, | ||
| "name": "Bow" | ||
| }, | ||
| { | ||
| "id": "/Syndicates/[a-zA-Z]+/Bows?", | ||
| "regex": true, | ||
| "name": "Bow" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Infested/LongGuns/InfArmCannon/InfArmCannon", | ||
| "name": "Shotgun" | ||
| }, | ||
|
Comment on lines
+1040
to
+1043
Member
There was a problem hiding this comment. Why bubonico should be classified as a shotgun? https://wiki.warframe.com/w/Bubonico |
||
| { | ||
| "id": "/Lotus/Weapons/Corpus/LongGuns/CrpSplitLaser/CrpSplitLaser", | ||
| "name": "Shotgun" | ||
| }, | ||
| { | ||
| "id": "/LongGuns/(Grn)?(Grenade|Cannon)[a-zA-Z]*/", | ||
| "regex": true, | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Corpus/LongGuns/CrpBriefcaseLauncher/CrpBriefcaseLauncher", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/ClanTech/Chemical/RocketLauncher", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/ClanTech/Bio/BioWeapon", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Syndicates/PerrinSequence/LongGuns/PSPenta", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Tonkor/KuvaTonkor", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Ogris/KuvaOgris", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Grineer/KuvaLich/LongGuns/Zarr/KuvaZarr", | ||
| "name": "Launcher" | ||
| }, | ||
| { | ||
| "id": "/LongGuns/[a-zA-Z]*Sniper(Rifle)?/", | ||
| "regex": true, | ||
| "name": "Sniper" | ||
| }, | ||
|
Comment on lines
+1081
to
+1085
Member
There was a problem hiding this comment. Shouldn't Ambassador be considered a rifle? https://wiki.warframe.com/w/Ambassador |
||
| { | ||
| "id": "/(Tenno|Grineer|Corpus)/Rifle/[a-zA-Z]*Sniper(Rifle)?", | ||
| "regex": true, | ||
| "name": "Sniper" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/ClanTech/Energy/Railgun", | ||
| "name": "Sniper" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/RubicoPrime/RubicoPrimeWeapon", | ||
| "name": "Sniper" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Infested/InfestedLich/LongGuns/CodaSporothrix", | ||
| "name": "Sniper" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeLightningGun/PrimeLightningGun", | ||
| "name": "Sniper" | ||
| }, | ||
| { | ||
| "id": "/Lotus/Weapons/Tenno/LongGuns/PrimeVectis/PrimeVectisRifle", | ||
| "name": "Sniper" | ||
| }, | ||
| { | ||
| "id": "/LongGuns", | ||
| "name": "Rifle" | ||
|
|
@@ -1062,4 +1235,4 @@ | |
| "id": "Challenges/Seasons", | ||
| "name": "Nightwave Challenge" | ||
| } | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Kuva Twin Stubbas be considered a dual pistol? https://wiki.warframe.com/w/Kuva_Twin_Stubbas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Kuva Brakk be considered a shotgun? https://wiki.warframe.com/w/Kuva_Brakk