Quick Choice - Fixed clipping issues with visual card displays on small form factors #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force 1 column display for visual cards on small form factors, even if user selects 2 columns Visual cards are now always responsive, the isResponsive selector has been removed from the CPE Dual column visual cards now always have the same height, the isSameHeight selector has been removed from the CPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a requirement to use dual column Visual Cards on large/medium form factors, but still have the flow be friendly and usable on smaller form factors. There were some clipping and reactivity issues with the visual cards on smaller form factors when using dual columns, so I made the following fixes/changes:
I couldn't think of any scenarios where having non-responsive single column cards or varied height cards in a dual column layout would be desirable, so I deprecated those configuration options and removed them from the CPE. Please correct me if I'm making a bad assumption here!
Before (mobile):
After (mobile):
Noticed after the fact that prettier ran on this, there wasn't a .prettierrc in the repo though so figured I'd send the PR anyway. First time contributing here so let me know if anything needs adjusted.